Repository navigation
fix(trading): bump LEAN Pkcs and Xml locks to 10.0.13 - #1098
Merged
seathatflowsinourveins merged 1 commit intoOct 13, 2026
Merged
Conversation
seathatflowsinourveins
marked this pull request as ready for review
October 13, 2026 23:01
seathatflowsinourveins
deleted the
codex/ns2604-osv-lean-locks-20261013
branch
October 13, 2026 23:14
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Clear the required OSV failures caused by
System.Security.Cryptography.Pkcsand.Xml10.0.10 in the retained LEAN graph. Add a source-level Xml 10.0.13 version floor in Messaging and regenerate the four affected locks with the pinned .NET SDK; Xml's own dependency raises Pkcs to 10.0.13. This keeps the published locked-restore recipe reproducible.329985de1c8dccf0df7491373d0d9932eaa723d4(freshorigin/main).lane:trading.blueprints/us-equities/engine/patches/lean-dependencies.patch, the Launcher/Messaging/Report/Tests files underengine/patches/lean-locks,engine/resolution.mdand their six registrations inmanifests/evidence.json.SOTA sources
e34a38d2aeas reported by the installeddotnet --info. Its official Linux x64 SDK archive was verified against the SHA-512 in Microsoft's official .NET 10 release metadata, matching the repository's original runtime pin. Full publisher metadata, installed-version output and CLI help are retained.3725139b4d18c135917b7c5d0f31f67f68115c2f,docs/core/tools/dotnet-restore.md:110-112,124-126,156-158:--force-evaluatereevaluates dependencies even with an existing lock;--use-lock-filegenerates and uses locks;--locked-moderefuses lock updates. The actual SDK 10.0.401dotnet restore --helpconfirms all three options. Regeneration uses--use-lock-file --force-evaluate; verification uses--locked-mode --forceagainst the published source patch.985ef30ad3ac774218c5ac516b4cb0aa2655730fis the blueprint's unchanged engine source pin. The existing three dependency replacements remain; the vendordotnet add ... package ... --version 10.0.13 --no-restorecommand adds one Xml reference to Messaging, and native Git produces the published patch. The Microsoft Xml 10.0.13 package requires Pkcs 10.0.13; its installed, unmodified.nuspecand native lock output establish that edge.gh run view --log, from #1097 run 38468742363 / job 115542031292 and main run 38461582449. No alternate advisory source supplies the IDs below. Separate extended-hours paper startup readiness from order freshness #1097's later report contains all five; the earlier main report contains three of them.e840a6e8adb14b7777c78e26cfbf6e2abc1d1fc6, the existing required workflow pin. The checksum-verified native executable and actual workflow scan command are reused. Scanner configuration, input inventory, severity handling and frozen-evidence policy remain unchanged.Advisory IDs from the two CI logs
Evidence-class table
native_provenlocal_integration.nuspecretainedlocal_integrationdotnet restore --locked-mode --forceexits 0, all 22 projects restoredlocal_integrationNo issues found, ordinary=0local_integrationnative_proven3b72f189075c42ecbae364ddfd5fe7eb94e2ab49: job SUCCESS; native log reports 23 metadata-guard tests passed, all 60 ordinary inputs scanned,No issues found, ordinary=0Local commands run
All heavy local commands, including restore, scanner invocations, suites, full validation, gitleaks and push hooks, run under
systemd-run --user --scope -p CPUWeight=idle --quiet --. Scratch, SDK, native package caches and source checkout are task-owned under/var/tmp. A missing ICU prerequisite was supplied through a task-local distribution package prefix; SDK globalization, host packages and global configuration were not changed.Decision record
The supported NuGet source input belongs in the LEAN patch: a lock-only version edit would disagree with Messaging's project graph and could revert on the next forced evaluation. One direct Xml version floor is sufficient because Xml 10.0.13 requires Pkcs 10.0.13. It propagates through Messaging to Launcher, Report and Tests. Only those four locks change, with native content hashes, dependency edges and the direct/project dependency metadata written by NuGet. No unrelated package version changes.
No dedicated LEAN lock-resolution test was found under this repository's
tests/orscripts/. The existing engine replay recipe's native full-solution locked restore is the compatibility check used here. This PR does not claim another build, backtest, strategy result, broker connection or entitlement check. The original September resolution receipt, its historical hashes and its original backtest result remain retained; the active guide distinguishes this maintenance graph from that historical run.This is the prerequisite landing fix for #1097 and other PRs blocked by the scanner. Gates remain enforced; those PRs need fresh CI after this bump lands. Required
osv-scannerjob115556275354and security workflow run38472902496both completed SUCCESS on this PR at exact head3b72f189075c42ecbae364ddfd5fe7eb94e2ab49. The complete hosted log reports the metadata guards passing, all 60 ordinary inputs scanned,No issues foundandOSV primary exit code: ordinary=0. The job API supplied no per-step array; success is established by the job conclusion plus its actual execution log, without inventing per-step metadata. Hosted log SHA-256:b059c9bc8c12e62d03b995a24c0f04615bb66cb0086f1b0edc6b9b1537433ba7. Other validation workflows and reviews remain separate; the CC lands this prerequisite first.Follow-ups
The CC's disposition (a), relayed at 2026-10-13 22:16Z, defers these two local-review P2s. They remain outstanding; this body update does not add a source commit.
Host evidence
Not applicable; no
evidence/hosts/changes. No credential file, broker account, paper STOP, live order, subscription or model call is involved.Checklist