Repository navigation
Validate dated grant counts and the newest advisory delta - #1030
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7aea6902c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Add the exact repository grant derived by scripts/local_pages_policy_grants.py at 72e4c17 and build the fixture no-reply identity at run time. The fail-first checks reproduce two missing-grant assertions and one fixture-identity assertion; both owning modules pass after correction. Verify the fixture author with native Git %ae: git/git@67ad421, Documentation/pretty-formats.adoc:195 (Git 2.53.0). Restate the pinned g5 attachment coverage as 368 of 373, with independent witnesses for the other five. Registry rebase onto landed #1030 (6658473) preserves the original historical advisory baseline and skill-use delta bytes. Record the new #1016 monitoring observation through a separate dated append rather than rebinding those historical records. Raw protected-source hashes and retention decisions remain unchanged.
Use the landed #1030 append contract at 6658473, blueprints/runtime-workers/openhands/evidence/advisory-gate-deltas.md. Native GitTree/derive_ci_protected at the recorded source commit supplies the complete 344-read baseline; the relative delta is empty because that baseline contains every observed read and shape. Preserve the historical 2026-10-04 baseline and 2026-10-11 skill-use delta bytes from landed main. Append one own 2026-10-12 index entry and register its new snapshot/delta through the native evidence writer. Monitoring only; no worker permission or execution authority changes.
Restate the finalization record for the preserved 332-read historical baseline and the own 344-read, 100-shape dated snapshot at d5e4d4a. Cite the landed #1030 append contract at 6658473, advisory-gate-deltas.md; add no label to historical source_files_sha256 fields. Re-register only the changed record through the native evidence writer. Advisory bytes, source commit, classifications and policy remain unchanged.
Add the exact repository grant derived by scripts/local_pages_policy_grants.py at 72e4c17 and build the fixture no-reply identity at run time. The fail-first checks reproduce two missing-grant assertions and one fixture-identity assertion; both owning modules pass after correction. Verify the fixture author with native Git %ae: git/git@67ad421, Documentation/pretty-formats.adoc:195 (Git 2.53.0). Restate the pinned g5 attachment coverage as 368 of 373, with independent witnesses for the other five. Registry rebase onto landed #1030 (6658473) preserves the original historical advisory baseline and skill-use delta bytes. Record the new #1016 monitoring observation through a separate dated append rather than rebinding those historical records. Raw protected-source hashes and retention decisions remain unchanged.
Use the landed #1030 append contract at 6658473, blueprints/runtime-workers/openhands/evidence/advisory-gate-deltas.md. Native GitTree/derive_ci_protected at the recorded source commit supplies the complete 344-read baseline; the relative delta is empty because that baseline contains every observed read and shape. Preserve the historical 2026-10-04 baseline and 2026-10-11 skill-use delta bytes from landed main. Append one own 2026-10-12 index entry and register its new snapshot/delta through the native evidence writer. Monitoring only; no worker permission or execution authority changes.
Restate the finalization record for the preserved 332-read historical baseline and the own 344-read, 100-shape dated snapshot at d5e4d4a. Cite the landed #1030 append contract at 6658473, advisory-gate-deltas.md; add no label to historical source_files_sha256 fields. Re-register only the changed record through the native evidence writer. Advisory bytes, source commit, classifications and policy remain unchanged.
Add the exact repository grant derived by scripts/local_pages_policy_grants.py at 72e4c17 and build the fixture no-reply identity at run time. The fail-first checks reproduce two missing-grant assertions and one fixture-identity assertion; both owning modules pass after correction. Verify the fixture author with native Git %ae: git/git@67ad421, Documentation/pretty-formats.adoc:195 (Git 2.53.0). Restate the pinned g5 attachment coverage as 368 of 373, with independent witnesses for the other five. Registry rebase onto landed #1030 (6658473) preserves the original historical advisory baseline and skill-use delta bytes. Record the new #1016 monitoring observation through a separate dated append rather than rebinding those historical records. Raw protected-source hashes and retention decisions remain unchanged.
Use the landed #1030 append contract at 6658473, blueprints/runtime-workers/openhands/evidence/advisory-gate-deltas.md. Native GitTree/derive_ci_protected at the recorded source commit supplies the complete 344-read baseline; the relative delta is empty because that baseline contains every observed read and shape. Preserve the historical 2026-10-04 baseline and 2026-10-11 skill-use delta bytes from landed main. Append one own 2026-10-12 index entry and register its new snapshot/delta through the native evidence writer. Monitoring only; no worker permission or execution authority changes.
Restate the finalization record for the preserved 332-read historical baseline and the own 344-read, 100-shape dated snapshot at d5e4d4a. Cite the landed #1030 append contract at 6658473, advisory-gate-deltas.md; add no label to historical source_files_sha256 fields. Re-register only the changed record through the native evidence writer. Advisory bytes, source commit, classifications and policy remain unchanged.
…overage (#1016) * Finalize starred categories and retention with guarded source coverage * fix(stars): reproduce protected citations and pins at named heads * fix(stars): register producer and correct provenance claims Add the exact repository grant derived by scripts/local_pages_policy_grants.py at 72e4c17 and build the fixture no-reply identity at run time. The fail-first checks reproduce two missing-grant assertions and one fixture-identity assertion; both owning modules pass after correction. Verify the fixture author with native Git %ae: git/git@67ad421, Documentation/pretty-formats.adoc:195 (Git 2.53.0). Restate the pinned g5 attachment coverage as 368 of 373, with independent witnesses for the other five. Registry rebase onto landed #1030 (6658473) preserves the original historical advisory baseline and skill-use delta bytes. Record the new #1016 monitoring observation through a separate dated append rather than rebinding those historical records. Raw protected-source hashes and retention decisions remain unchanged. * evidence(stars): append the dated PR1016 advisory observation Use the landed #1030 append contract at 6658473, blueprints/runtime-workers/openhands/evidence/advisory-gate-deltas.md. Native GitTree/derive_ci_protected at the recorded source commit supplies the complete 344-read baseline; the relative delta is empty because that baseline contains every observed read and shape. Preserve the historical 2026-10-04 baseline and 2026-10-11 skill-use delta bytes from landed main. Append one own 2026-10-12 index entry and register its new snapshot/delta through the native evidence writer. Monitoring only; no worker permission or execution authority changes. * docs(stars): describe the current dated monitoring observation Restate the finalization record for the preserved 332-read historical baseline and the own 344-read, 100-shape dated snapshot at d5e4d4a. Cite the landed #1030 append contract at 6658473, advisory-gate-deltas.md; add no label to historical source_files_sha256 fields. Re-register only the changed record through the native evidence writer. Advisory bytes, source commit, classifications and policy remain unchanged.
Scope
A later tracked script or baseline refresh could make #970’s dated count and advisory assertions fail unrelated PRs. This correction separates historical inputs from current monitoring: dated grant counts use the record’s explicit Git pin, and the advisory check validates the newest dated delta against its referenced baseline and current native derivation. Every committed historical index remains an unchanged prefix; its delta and baseline bytes are independently preserved from Git objects.
8b1ef0c37e2f523aa84d2c75960540f45e74e814.lane:foundation.e7aea6902cf15c9ed23a57c2a75818f923561f03(four commits; no rebase).The decision's counts are preserved. Its durable inventory-validation pin is #970's landed squash
900835c60ce9890cd704df4e98ded0b8aa91977d, an ancestor of main with the same 97-path inventory as the original amended carry input. The original source history remains labeled historical. This avoids making the test depend on an unreachable PR-source commit after squash.Dated advisory baseline/delta extension
blueprints/runtime-workers/openhands/evidence/unclassified-gate-read-deltas.jsonrecords dated delta filenames in chronological UTC-date order; append order breaks same-date ties. The checker selects the last entry. Each historical baseline must still match the hash recorded by its own delta. Only the newest delta’s script, shape, total, classification and protection accounting is compared with the current native derivation.The correction to Astra’s P2 reads all prior index versions reachable from the tested tree’s resolved Git commit using
git rev-list --full-history <commit> -- <index-path>. Every prior entries array must remain an unchanged prefix. Its historical delta and baseline bytes are also read independently through the existing nativeGitTree, so deleting an entry or editing its expected hash cannot remove preservation coverage. A committed removal fails too. Full Git history is required; the existing validation workflow usesfetch-depth: 0.A PR that changes advisory reads appends its own delta with its native
derived_count. If it refreshes a baseline, it writes a separately dated snapshot and points the new delta at it; neither the old snapshot nor the 2026-10-11 skill-use delta is overwritten. The public append/derivation protocol describes the schema and native APIs for #949’s follow-on delta.The new fixture uses
derive_ci_protectedto add one advisory read, builds a fresh complete baseline and appends its new delta. Old logic ignores that entry and fails; new logic passes. The fix-round regression rejects removal with or without a baseline rewrite, for later and same-date observations, plus a committed omission and a joint historical-delta/baseline rewrite. Valid appends remain accepted. Both historical files in this PR are byte-for-byte unchanged.The final correction seeds the refresh fixture's own committed Git history before its first checker call and binds its candidate files and native
GitTreeto that isolated repository. An added regression commits a valid same-date observation in a shared outer clone, verifies acceptance, runs the refresh fixture and its refusal controls, and separately rejects omission, reorder and entry editing in the outer checkout. The production preservation assertions are unchanged. Both Git blob-output locators now cite line 27, verified at the installed Git pin; their evidence registrations are refreshed.The protocol also states the frozen-history consequence: a follow-on PR whose committed delta needs a fix after its first push may only append a superseding entry or rewrite its branch.
SOTA sources
Installed Git 2.53.0,
git/[email protected], commit67ad42147a7acc2af6074753ebd03d904476118f, read from the official source mirror: git-ls-tree.adoc documents recursive trees, NUL termination and name-only output; git-show.adoc:27 documents plain blob contents; revisions.adoc:217-220 documents<rev>:<path>.At the same Git pin, git-rev-list.adoc:65-70 documents path-limited commit enumeration, and rev-list-options.adoc:520-525 documents following all merge parents with
--full-history. The check reads durable commit objects without trusting mutable remote refs or a candidate-selected comparison pin.The outer regression uses supported local Git commands at the same pin: git-clone.adoc:80-85 (
--shared), :160-161 (--no-checkout) and git-checkout.adoc:66-71 (--detach).Existing native selector at scripts/local_pages_policy_grants.py:46,
inventory_paths. The correction reuses this selector with Git-read historical inputs. It does not create a second inventory policy.Existing native advisory derivation at push_gate.py:665,
derive_ci_protected, with the native reader defined at patch_policy.py:55,GitTree; exact script and shape multiplicities remain enforced.Locally installed CPython 3.13.16,
python/cpython@cbc944f4bc59639a444dd971c737788ba2283a91: JSON loads, ISO date parsing, and Path.resolve. Official pinned source was read; no new runtime dependency. CI interpreter citation is a separate follow-up below.Evidence-class table
02763f27checker fails; the corrected checker accepts valid appends and rejects removed entries and rebound historical bytes.2ffc23b2refresh fixture then fails; the corrected fixture passes, retaining omission/reorder/edit refusal.Local commands run
Both required regression methods were overlaid on main
8b1ef0c3without changing its checked logic: the tracked-path case fails 97 !=98, and the baseline-refresh case fails because the original check ignores the later delta. Two failures, zero errors, rc1, in 15.626s.Round 1 fail-before at
2ffc23b2: its fixture with the exact Git-read checker from02763f27d8c9b2d83da51e64848dd78c3dcf88c1failed six controls (later/same-date omission with and without baseline rewriting, joint historical-delta/baseline rewriting, and committed omission): one test, six failures, zero errors, rc1, in 21.514s; its corrected checker passed in 16.906s. Round 2 repeats the corrected isolated fixture against that same02763f27checker: six expected failures, zero errors, rc1, in 13.509s. Public historical baseline/delta bytes remain unchanged.Round 2 fail-before: the new outer-checkout regression against the exact Git-read
2ffc23b2refresh fixture gives one failure, zero errors, rc1 (17.360s). Direct acceptance succeeds first; the old refresh fixture then fails its synthetic-prefix comparison. The three focused checks pass at the committed final head, rc0 (26.388s). The original omission/rebound/committed-omission controls remain active.Current owning-module validation ran separately under idle-class scopes: 127 push-gate tests, zero skips, rc0 (93.443s), then five skill tests, zero skips, rc0 (0.783s). Native integrity validation was rerun after all four final payload registrations.
Earlier validation includes an initial native-zizmor host-shim prerequisite failure, cleared using installed pinned tools without changing expectations. Current checks use the retained installed Python 3.13.16 tool directory. No full repository suite or live/provider run is claimed.
Decision record
Existing skill invoke-rate record, now naming its durable inventory-validation commit and the pinned Git mechanism. The dated counts and #1016's dated record are not rewritten.
Host evidence
No host receipt or platform-status change. Only public Git objects and metadata are read. No provider, model, service or account probe is run.
Checklist
Follow-ups
Class: dated-record/live-state coupling. Freeze the inputs of historical assertions; keep intentionally live projections separate. The bounded historical sweep scanned 361 test files, retained 48 AST/read/count candidates and source-reviewed the comparisons below. Retain its captured locators as historical inputs and map current symbols separately when continuing classification. These remain review targets; the capture does not establish that every candidate is a defect.
tests/test_skill_correction_claims.py:142(base:93)tests/test_new_wsl_client_config.py:5212tests/test_new_wsl_client_config.py:5191tests/test_primary_source_reading_counts.py:411tests/test_edgartools_pin_move.py:17The sweep also distinguishes intended current projections in
tests/test_new_wsl_definitive_defaults.py:1020andtests/test_handbook_summary.py:50, the advisory baseline/delta contract now corrected in this PR (tests/test_runtime_worker_openhands_push_gate.py, newest-entry check), and retained-input checks intests/test_host_baseline_probe.py:606andtests/test_claude_federation_diagnostics.py:47. Static filters do not prove absence through arbitrary dynamic paths/helpers. The complete candidate inventory and scope notes are retained asdated-grant-correction-20261012/SWEEP.jsonandSWEEP.md.If the inventory selector itself changes, review the historical-selector semantics independently of this tree/catalog/policy snapshot correction. Follow-up baseline publishers must use the append-only dated-entry protocol; keep location-list-versus-derivation coverage as the previously recorded P3. Both review families are to read the final correction delta; the CC owns landing before the dependent follow-on PRs.
The nine Astra round-2 P3s below retain the earlier Claude follow-ups too. B2's two Git-show locators are fixed; these items do not reopen the terminal fix round:
tests/test_runtime_worker_openhands_push_gate.py:1392. Separate intentional latest projections from historical assertions and proven defects. Astra verified both attached captures and all 48 named functions; the earlier missing-capture gap is closed.inventory_pathsimplementation (tests/test_skill_correction_claims.py:87). Independently review selector-version semantics and historical location-list/source-commit verification (tests/test_runtime_worker_openhands_push_gate.py:1493, :1509). This fixture correction does not claim to solve those boundaries.manifests/evidence.json:4155, with zero in added lines or the body. The matched value is omitted.Documentation/git-ls-tree.adoc:82for--full-tree; :44-61 covers the other listed switches. Correct the protocol introduction's attribution:GitTreeis inresolver/patch_policy.py:55, whilederive_ci_protectedis inresolver/push_gate.py:665. Re-register changed public bytes in that follow-up; the body source links already distinguish them.YYYY-MM-DD, compare parsed dates'.isoformat()with their original strings and cover accepted/refused spellings.date.fromisoformatalso accepts compact forms (tests/test_runtime_worker_openhands_push_gate.py:1409); this remains optional hardening.unclassified-gate-reads-outer-fixture-delta.jsonis unused (tests/test_runtime_worker_openhands_push_gate.py:1252, :1255). Astra reproduced a valid committed observation with that basename: the production checker accepts it, then the regression duplicates the path and fails uniqueness (2 != 3, one failure/zero errors, rc1). Choose a synthetic basename absent from both the existing index and files before copying/appending, and retain a regression containing the formerly colliding name. This adjacent P3 is a follow-up under the terminal ruling; ordinary append and B1/B2 checks pass.Follow-ups from Codex at
e7aea690(CC ruling, 2026-10-12T10:50:37Z)These are P2 hardening items. Round 2 of 2 is complete and both families pass at
e7aea690, so under the terminal rule they do not reopen the PR. Each goes to a follow-on PR with a failing regression:source_commitby deriving the observation from aGitTreeat that pin, and add an invalid-pin regression (thread PRRT_kwDOUg_LrM6rZwCd).added_locationsandremoved_locationsagainst the native location difference, and add tamper regressions for each side (thread PRRT_kwDOUg_LrM6rZwCp).