Repository navigation
Derive repository grant count from reviewed policy - #1013
Merged
seathatflowsinourveins merged 2 commits intoOct 11, 2026
Merged
seathatflowsinourveins merged 2 commits into
seathatflowsinourveins merged 2 commits into
Conversation
seathatflowsinourveins
marked this pull request as ready for review
October 11, 2026 18:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seathatflowsinourveins
force-pushed
the
foundation/engine-qual-grant-count-derivation-20261011
branch
from
October 11, 2026 21:57
0ce6575 to
42b2b03
Compare
seathatflowsinourveins
deleted the
foundation/engine-qual-grant-count-derivation-20261011
branch
October 11, 2026 22:21
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Concurrent inventory-grant additions currently require editing the same numeric test assertion. Derive its expected repository-grant count from the policy's repository rows so future grant additions need no test-count edit, while preserving the independent exact Git-inventory comparison.
42b2b03986b8de23018c387c502443fad790ba18; the CC builder rebased and pushed the two commits, with carry PASS. The grant test is byte-identical to the previously reviewed0ce65753(Git blobaf578dc204a38750752b36d485dbe347f6006c31). Merged at 2026-10-11T22:21:44Z.bcf55c457d057c71faceeab068bdd02017c43342(current main at branch creation).lane:foundation.tests/test_local_pages_policy_grants.pyand its hash/byte registration inmanifests/evidence.json.SOTA sources
bcf55c457d057c71faceeab068bdd02017c43342: source_policy.json, inventory_paths, and the existing independent inventory assertion at tests/test_local_pages_policy_grants.py:74-81. The policy and production selector are unchanged.cbc944f4bc59639a444dd971c737788ba2283a91(installed Python 3.13.16 reference mirror): Python/bltinmodule.c:2578, supportedsumover the Boolean repository-row predicate; Lib/unittest/mock.py:1764, supported temporary fixture patches. Exact pinned-source excerpts/blob identities are retained in the local evidence packet.Evidence-class table
92 != 91before the fix, GREEN.json passes afterwardWhy the derivation is not vacuous
The count compares unique policy paths with the number of repository policy rows, so duplicate rows now also fail. The previous literal counted unique paths and accepted duplicate rows; rejecting duplicates is new in this PR. The existing
actual == expectedassertion remains unchanged:expectedstill comes independently fromgit ls-filesthrough the existing reviewed selector and catalog metadata. A missing or extra grant fails that exact-set comparison, and a replacement with the same cardinality also fails. The four negative controls exercise these boundaries; every other original test method is unchanged.Local commands run
Retained local packet:
~/.local/state/native-agent-stack/coordination/ns2604-coop/lanes/engine-qual.grant-count-20261011/, including exact fail-before test bytes, input/output hashes, observed exits and pinned source excerpts. This is the original 7cdeacd packet; its historical method name and body used "still" for duplicate refusal and are superseded by the correction.Current wording-correction packet:
~/.local/state/native-agent-stack/coordination/ns2604-coop/lanes/engine-qual.grant-count-wording-20261011/, with the renamed final source, current test/validator observations and the base-versus-head duplicate control.Decision record
No repository rule or production grant changes. This adopts a source-derived test expectation within the existing policy/selector contract.
Host evidence
Not applicable: no
evidence/hosts/receipt or platform-status change.Follow-ups
manifests/evidence.json, counted only; no identifier is published here. Later normalization must update dependent integrity records together.The CC owns the landing order; this PR is merged at the head/time above and made no edits to peer PR branches.
Checklist