to_lab Integration candidate: 2021-03-30#97
Merged
Conversation
It is not necessary for applications to register themselves, this is all done automatically.
Fix #95, remove app registration
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #95, remove app registration
Testing
to_lab checks https://github.com/nasa/to_lab/pull/97/checks
bundle checks https://github.com/nasa/cFS/pull/227/checks
Expected behavior changes
PR #95
Removes app registration call,
CFE_ES_RegisterApp()since applications do not need to register themselves.Additional context
Part of nasa/cFS#227
Third party code
None
Authors
@jphickey