to_lab Integration Candidate: 2020-12-22#75
Merged
Conversation
Remove all was also removing subscriptions from the command pipe, which leaves TO inoperable. The remove all command now just removes all subscriptions to the Tlm_pipe
Fix #71, Remove all only from telemetry pipe
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #71, Remove all only from telemetry pipe
Testing performed
See https://github.com/nasa/cFS/pull/162/checks
Expected behavior changes
PR #74 - TO remains commandable after a remove all subscriptions command; the command now only removes all subscriptions to the Tlm_pipe
System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#162
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper