Fix #71, Remove all only from telemetry pipe#74
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 18, 2020
Merged
Fix #71, Remove all only from telemetry pipe#74astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Remove all was also removing subscriptions from the command pipe, which leaves TO inoperable. The remove all command now just removes all subscriptions to the Tlm_pipe
skliper
added
the
CCB:Ready
astrogeco
added
CCB-20201216
and removed
CCB:Ready
Contributor
|
CCB 2020-12-16 APPROVED Spawned some new issues
Brings up the question: are we "fully testing" the lab apps? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #71 - updated remove all to only remove Tlm_pipe subscriptions
Remove all was also removing subscriptions
from the command pipe, which leaves TO
inoperable. The remove all command now
just removes all subscriptions to the Tlm_pipe
Testing performed
Native build, sent remove all subscriptions cmd and confirmed, sent to noop multiple times and confirmed receipt
Expected behavior changes
TO remains commandable after a remove all subscriptions command
System(s) tested on
Additional context
TO should mark empty slots with invalid MSGID, and not try to unsubscribe them - #72
TO should remove PktSize from packet add command (unused) - #73
GroundSystem add packet command definition needs update (Stream -> MsgId, should accept hex msgid, fix contents since they don't map correctly) - nasa/cFS-GroundSystem#141
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC