Fix #56, Add header guard to to_lab_sub_table.h#57
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 26, 2020
Merged
Fix #56, Add header guard to to_lab_sub_table.h#57astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
enhancement
CDKnightNASA
approved these changes
Aug 21, 2020
astrogeco
reviewed
Aug 26, 2020
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Do we have a style guide for header guards? I wonder if we should use all caps.
Contributor
Author
|
GSFC 582 coding standard (C_Coding_Standard_20051129) recommendation says match file case. |
Contributor
|
CCB 2020-08-26 - APPROVED, might want to open issues to standardize include guards across components |
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #56 - add header guard to to_lab_sub_table.h
Testing performed
Build and run - no issues
Expected behavior changes
No impact to behavior, good design practice
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC