Skip to content

Fix #41, remove dependencies on CCSDS types#42

Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom
jphickey:fix-41-ccsds-refs
Jun 3, 2020
Merged

Fix #41, remove dependencies on CCSDS types#42
astrogeco merged 2 commits intonasa:integration-candidatefrom
jphickey:fix-41-ccsds-refs

Conversation

@jphickey
Copy link
Contributor

Describe the contribution
Replace references to ccsds.h types with the cfe_sb.h-provided type.

Fixes #41

Testing performed
Build and sanity check CFE, run all unit tests

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 28, 2020
@skliper skliper added CCB:FastTrack enhancement New feature or request labels May 29, 2020
@skliper skliper added this to the 2.4.0 milestone May 29, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate June 1, 2020 18:13
@astrogeco astrogeco added IC-20200526 conflicts There are conflicts preventing this PR from being merged labels Jun 1, 2020
@astrogeco
Copy link
Contributor

@jphickey see conflicts

Applications should only use types provide by CFE_SB.
@jphickey jphickey force-pushed the fix-41-ccsds-refs branch from 9ccbc32 to 862a9ee Compare June 3, 2020 02:22
@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2020

Rebased to master. Always impossible to merge across a formatting fixup commit.

@astrogeco astrogeco removed the conflicts There are conflicts preventing this PR from being merged label Jun 3, 2020
@astrogeco astrogeco merged commit 491e2ce into nasa:integration-candidate Jun 3, 2020
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 24, 2020
@jphickey jphickey deleted the fix-41-ccsds-refs branch June 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:FastTrack enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove references to "CCSDS" structures

3 participants