Fix #54, Use MSG APIs#55
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 1, 2020
Merged
Conversation
skliper
added
the
CCB:Ready
Contributor
|
CCB 2020-11-12 APPROVED |
Contributor
|
FWIW - I am still of the opinion we should hold off on making changes to apps until we have the correct API alignment patterns/requirements settled as per nasa/cFE#1009 (comment) (Or in other words, there might be a good reason to keep the local TLM union buffer around) |
astrogeco
added
CCB-20201112
and removed
CCB:Ready
Contributor
Author
|
Can this move forward? I'm doing changes for nasa/cFE#1009 on top of these... aka #56. |
jphickey
approved these changes
Nov 17, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Yes, I think we have agreement on the path forward here.
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 1, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Replaces deprecated SB API's with MSG
Fix #54
Testing performed
Built and ran, enabled telemetry, checked noops
Expected behavior changes
None
System(s) tested on
Additional context
nasa/cFE#777
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC