Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thnkslprpt
force-pushed
the
fix-141-convert-int32-return-codes-to-CFE_Status_t
branch
from
052dea4 to
cd7c2a9
Compare
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 SCH_LAB_AppInit(void) | ||
| CFE_Status_t SCH_LAB_AppInit(void) |
Check notice
Code scanning / CodeQL
Function too long
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 SCH_LAB_AppInit(void) | ||
| CFE_Status_t SCH_LAB_AppInit(void) |
Check notice
Code scanning / CodeQL
Long function without assertion
thnkslprpt
force-pushed
the
fix-141-convert-int32-return-codes-to-CFE_Status_t
branch
from
cd7c2a9 to
9b24dd9
Compare
| {CFE_SB_MSGID_WRAP_VALUE(CFE_EVS_SEND_HK_MID), 96, 0}, | ||
|
|
||
| /* Example of including additional open source apps */ | ||
| #ifdef HAVE_CI_LAB |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_CI_LAB | ||
| {CFE_SB_MSGID_WRAP_VALUE(CI_LAB_SEND_HK_MID), 95, 0}, | ||
| #endif | ||
| #ifdef HAVE_TO_LAB |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_TO_LAB | ||
| {CFE_SB_MSGID_WRAP_VALUE(TO_LAB_SEND_HK_MID), 94, 0}, | ||
| #endif | ||
| #ifdef HAVE_SAMPLE_APP |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_SAMPLE_APP | ||
| {CFE_SB_MSGID_WRAP_VALUE(SAMPLE_APP_SEND_HK_MID), 93, 0}, | ||
| #endif | ||
| #ifdef HAVE_SC |
Check notice
Code scanning / CodeQL
Conditional compilation
| {CFE_SB_MSGID_WRAP_VALUE(SC_SEND_HK_MID), 92, 0}, | ||
| {CFE_SB_MSGID_WRAP_VALUE(SC_1HZ_WAKEUP_MID), 91, 0}, | ||
| #endif | ||
| #ifdef HAVE_HS |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_HS | ||
| {CFE_SB_MSGID_WRAP_VALUE(HS_SEND_HK_MID), 90, 0}, /* Example of a message that wouldn't be sent */ | ||
| #endif | ||
| #ifdef HAVE_FM |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_FM | ||
| {CFE_SB_MSGID_WRAP_VALUE(FM_SEND_HK_MID), 101, 0}, | ||
| #endif | ||
| #ifdef HAVE_DS |
Check notice
Code scanning / CodeQL
Conditional compilation
| #ifdef HAVE_DS | ||
| {CFE_SB_MSGID_WRAP_VALUE(DS_SEND_HK_MID), 102, 0}, | ||
| #endif | ||
| #ifdef HAVE_LC |
Check notice
Code scanning / CodeQL
Conditional compilation
jphickey
approved these changes
Oct 24, 2023
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
and removed
CCB:Ready
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 13, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
thnkslprpt
deleted the
fix-141-convert-int32-return-codes-to-CFE_Status_t
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
int32return codes and variables should be converted toCFE_Status_t#141int32return codes converted over toCFE_Status_tedit: some formatting issues cropped up after a recent PR went through
Testing performed
GitHub CI actions all passing successfully.
Local testing with full cFS suite passing all tests and showing not change to coverage.
Expected behavior changes
No change to behavior.
CFE_Status_tis more expressive and improves consistency with cFE/cFS.Contributor Info
Avi Weiss @thnkslprpt