Conversation
Replace inconsistent SAMPLE_ And SAMPLE_Lib prefixes, now all identifiers should start with SAMPLE_LIB_.
Fix #33, Standardize to SAMPLE_LIB_ namespace prefix
Makes sample_lib consistent with cfe and osal. See nasa/cFE#83 Also applies clang-format
astrogeco
force-pushed
the
integration-candidate
branch
from
420d484 to
4bea612
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
4bea612 to
96ba02b
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 4, 2020
Combines nasa/cFE#991 nasa/osal#639 nasa/PSP#213 nasa/sample_app#102 nasa/sample_lib#35 Co-authored-by: Joseph Hickey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #33, Standardize to SAMPLE_LIB_ namespace prefix
Testing performed
See framework-bundle CI: https://github.com/nasa/cFS/pull/154/checks
Expected behavior changes
PR #34 - No behavior changes. All identifiers now use the prefix
SAMPLE_LIB_. Changes the name of the init function from SAMPLE_LibInit to SAMPLE_LIB_Init which affects the CFE startup script.System(s) tested on
Ubuntu CI
Additional context
Part of nasa/cFS#154
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey