Merged
Conversation
The fully-rendered strings are not entirely consistent, affected by many external factors outside the control of the test cases. There was even a warning in the comment against doing this, but it was included nonetheless as an example of how it can be done. This now keeps the original example but keeps it in the comment only, and converts the actual test to follow the recommended practice of only testing the spec/format string, not the fully-rendered string. This should be much more stable going forward, and should work with both CCSDS v1 and v2 configs.
Fix #97, check only format string in UT event test
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 22, 2020
Integration Candidate includes: nasa/cFE#891 nasa/osal#600 nasa/PSP#196 nasa/sample_lib#32 nasa/sample_app#98
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 22, 2020
Integration Candidate: 2020-09-16 Includes: nasa/cFE#891 nasa/osal#600 nasa/PSP#196 nasa/sample_lib#32 nasa/sample_app#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #87
Fix #95
Fix #97
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/140/checks
Expected behavior changes
PR #94 - Unit test MID string format now 32bit
PR #96 - Installs unit test to target directory
PR #99 - Checks only format string in UT event test
System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#140
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC