Fix #66, Add extended context information to event hook#67
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jun 2, 2020
Merged
Conversation
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Add string validation to the sample event hook as an example of how to use the context information supplied to the hook to perform other validation.
jphickey
added
the
CCB:Ready
skliper
approved these changes
May 21, 2020
astrogeco
added
CCB-20200527
and removed
CCB:Ready
Contributor
|
CCB 2020-05-27 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add a string validation to the sample event hook as an example of how to use the context information supplied to the hook to perform this type of validation.
Fixes #66
Testing performed
Execute unit tests and confirm correct operation. all passing.
Expected behavior changes
Test cases now compare an expected event string with a string derived from the spec string and arguments that were output by the unit under test.
System(s) tested on
Ubuntu 20.04
Additional context
Depends on prerequisites/related tickets:
These are necessary to pass the full CFE_EVS_SendEvent context through to the hook function.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.