Merged
Conversation
Update SAMPLE to better correlate with the naming conventions used elsewhere and documented in the CFE naming conventions - Put all global runtime data into a single "SAMPLE_AppData" object - Name all global-scope identifiers consistently with a "SAMPLE_" prefix - Do not use SAMPLE prefix for members already inside global - Command handlers named to match the command they process - Command handlers return an int32 status value - Telemetry payload defined in a separate structure - Member names in telemetry struct following convention in the CFE naming convention document.
Put the HkTlm buffer into a union to ensure it is aligned appropriately for conversion to a CFE_SB_Msg_t type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate 20200304
Fixes #38 and #40
See PR #43 for more details
Testing performed
CI and Raspbian
Expected behavior changes
#38 - Builds in Raspbian OS
#40 - Consistent naming conventions
System(s) tested on
Additional context
See PR #43 for more details
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz - NASA/GSFC