Conversation
The CFE framework sample/lab applications did not have any example use-cases where a _library_ function was invoked. For the FSW verification aspect, it is important to do this at least in one place as it verifies that the run-time linking is working properly, not just for functions in the core image but also for dynamically loaded libraries. The unit test framework also needs to support this use case, to demonstrate that it can link against the stub provided by the library for the local UT. This just simply adds a call to the "SAMPLE_Function" provided by sample_lib to demonstrate this.
These were being copied to the telemetry packet backwards. Trivial fix.
The code must not dereference the pointer unless the call returned CFE_SUCCESS, otherwise the pointer is not valid.
When using printf-style format conversions one must generally cast the argument to the intended type, as it does not happen implicitly with variable-argument functions. In particular the existing code worked on the default (native) build but generated warnings when building on RTEMS for a 32-bit x86 target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #23, Fix #25, Fix #28, Fix #30
Testing performed
Expected behavior changes
See related pull requests
System(s) tested on
Additional context
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC