Invoke SAMPLE_Function as part of Process command#24
Merged
skliper merged 1 commit intomerge-20191230from Dec 30, 2019
Merged
Conversation
The CFE framework sample/lab applications did not have any example use-cases where a _library_ function was invoked. For the FSW verification aspect, it is important to do this at least in one place as it verifies that the run-time linking is working properly, not just for functions in the core image but also for dynamically loaded libraries. The unit test framework also needs to support this use case, to demonstrate that it can link against the stub provided by the library for the local UT. This just simply adds a call to the "SAMPLE_Function" provided by sample_lib to demonstrate this.
skliper
approved these changes
Dec 18, 2019
Contributor
|
CCB 20191218 - Reviewed and approved for IC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #23
Adds a call to the
SAMPLE_Function()provided by sample_lib as part of the example command processing.This is to demonstrate two things:
Testing performed
Build with ENABLE_UNIT_TESTS=TRUE, both with SIMULATION=native and for a 32-bit raspberry pi target.
Execute CFE code, and confirm that everything starts normally. SAMPLE_LIB is loaded first, and SAMPLE_APP is loaded next and no runtime linking issues are reported.
Log snippet:
Send the "PROCESS_CC` command and confirm that the function is invoked from SAMPLE_LIB:
Expected behavior changes
The PROCESS_CC command now makes a call into the sample library.
System(s) tested on:
Ubuntu 18.04 LTS 64-bit
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted