Skip to content

Comments

Fix #237, update sample app to reflect 582 standard#238

Merged
dzbaker merged 1 commit intonasa:mainfrom
avan989:Fix-237-Update-To-Reflect-582-Standard
Apr 7, 2025
Merged

Fix #237, update sample app to reflect 582 standard#238
dzbaker merged 1 commit intonasa:mainfrom
avan989:Fix-237-Update-To-Reflect-582-Standard

Conversation

@avan989
Copy link
Contributor

@avan989 avan989 commented Apr 2, 2025

Fix #237, Update to remove global pipename and data structure. Update cmd to increment command counter. Update SAMPLE_APP_ProcessCmd to have only 1 return.

Describe the contribution
A clear and concise description of what the contribution is.

  • Include explicitly what issue it addresses [e.g. Fixes #X]

Testing performed
Steps taken to test the contribution:

  1. Make SIMULATION=native install

  2. Run Test

  3. Make ENABLE_UNIT_TESTS=true SIMULATION=native

  4. Make test

  5. make lcov

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • If NASA Civil Servant Employee or GSFC Contractor on SES II
    • Address/email/phone and contract/task information (if applicable) must be on file
  • Else if Company
    • HAND SIGNED Company CLA must be on file (once per release): Company CLA
  • Else if Individual
    • HAND SIGNED Individual CLA must be on file (once per release): Individual CLA
      Anh Van, GSFC

Fix nasa#237, Update to remove global pipename and data structure. Update cmd to increment command counter. Update SAMPLE_APP_ProcessCmd to have only 1 return.
@dzbaker dzbaker added the CCB:Approved Indicates code approval by CCB label Apr 3, 2025
@chillfig chillfig added the enhancement New feature or request label Apr 3, 2025
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

*cFS*
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker mentioned this pull request Apr 7, 2025
2 tasks
@dzbaker dzbaker merged commit 10b3d2e into nasa:main Apr 7, 2025
10 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

*cFS*
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code approval by CCB enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to reflect 582 standard

4 participants