Fix #199, Add test for missing branch in SAMPLE_APP_Process()#200
Conversation
jphickey
approved these changes
Oct 26, 2023
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
thnkslprpt
deleted the
fix-199-add-test-for-missing-branch-in-SAMPLE_APP_Process
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
SAMPLE_APP_Process()with a seeded failure fromCFE_TBL_ReleaseAddress().CFE_ES_WriteToSysLog()(in this function, only this specific path would add 3 additional calls toCFE_ES_WriteToSysLog()).Testing performed
GitHub CI actions all passing successfully.
Tested locally confirming extra branch covered now, increasing branch coverage slightly (from 37/41 to 38/41 branches) and line cover to 100%.
Prior:
With these changes:
Expected behavior changes
Tests now cover an additional branch.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt