Conversation
Replace inconsistent SAMPLE_ and SAMPLE_App name prefixes, now all identifers should start with SAMPLE_APP_.
Fix #77, Standardize to SAMPLE_APP_ namespace prefix
This makes sample_app consistent with osal and cFE. See nasa/cFE#853 and nasa/osal#585 Also Applies clang-format
astrogeco
force-pushed
the
integration-candidate
branch
from
9d574ff to
4e5cd3f
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
4e5cd3f to
de7a6ad
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 4, 2020
Combines nasa/cFE#991 nasa/osal#639 nasa/PSP#213 nasa/sample_app#102 nasa/sample_lib#35 Co-authored-by: Joseph Hickey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #77, Standardize to SAMPLE_APP_ namespace prefix
Testing performed
See framework-bundle CI: https://github.com/nasa/cFS/pull/154/checks
Expected behavior changes
PR #100 - No behavior changes. All identifiers now use the prefix
SAMPLE_APP_. Changes the name of the main function from SAMPLE_AppMain to SAMPLE_APP_Main which affects the CFE startup script.System(s) tested on
Ubuntu CI
Additional context
nasa/cFS#154
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey