Fix #640, configuration guide updates#978
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom May 11, 2021
Merged
Fix #640, configuration guide updates#978astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Update the configuration guide for the current build system (CMake) and the currently provided set of OS/BSP layers. Many of the examples in this guide referred to items which are obsolete. However, this does *NOT* fix references to the applications and in particular the "tasking example" as this still may be brought back.
skliper
reviewed
Apr 30, 2021
| build can be done for testing and development purposes, it is expected that the OSAL will | ||
| be utilized as a component in a larger application. | ||
|
|
||
| ### Integrating OSAL into a larger build |
Contributor
There was a problem hiding this comment.
Love this, ping @ejtimmon for reference to reviving the tasking examples and adding c++ hello world
Contributor
|
CCB:2021-05-05 APPROVED with changes
|
astrogeco
previously requested changes
May 5, 2021
Contributor
astrogeco
left a comment
There was a problem hiding this comment.
Requesting changes as a reminder to look at comments
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
May 6, 2021
Adds various review items into the document, adds some new sections regarding the sample Makefile wrapper.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
May 6, 2021
Adds various review items into the document, adds some new sections regarding the sample Makefile wrapper.
a764a84 to
27a0866
Compare
Adds various review items into the document, adds some new sections regarding the sample Makefile wrapper.
27a0866 to
1f1cf53
Compare
skliper
approved these changes
May 6, 2021
astrogeco
approved these changes
May 11, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 11, 2021
nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575 nasa/osal#996, osal v5.1.0-rc1+dev434 nasa/cFE#1487, Remove broken travis-ci script nasa/cFE#1463, generated coverage stubs for CFE core nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API nasa/cFE#1451, OSAL config file simplification nasa/cFE#1489, removes --quiet option so files checked go to stdout nasa/osal#978, configuration guide updates nasa/osal#974, improve documentation of UtAssert API calls nasa/osal#977, update OS_TaskCreate doc nasa/osal#997, Enable cppcheck results output nasa/osal#980, Scrub return values nasa/osal#992, add local mutex to BSP console nasa/osal#993, do not require nonblock mode Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]>
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Implement a "CFE_ES_TaskStartParams_t" to complement the existing "CFE_ES_AppStartParams_t" and store this in the task record. This permits some nice cleanup: - All tasks can now use the same basic start function CFE_ES_StartAppTask() - No special/different logic is needed for main tasks/child tasks - Simplified APIs as parameters can be encapsulated in a single struct. - Fixes a race condition where child tasks may not be fully instantiated at the time the task function is invoked.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#978, put task parameters into task record
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Significant update to the configuration guide for the current build system (CMake) and the currently provided set of OS/BSP layers. Many of the examples in this guide referred to items which are now obsolete.
However, this does NOT fix references to the applications and in particular the "tasking example" as this still may be brought back.
Fixes #640
Testing performed
View guide in markdown viewer, confirm commands/pathnames in guide seem to match current version
Expected behavior changes
None - documentation only
System(s) tested on
Commands in document were validated on Linux and RTEMS where possible
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.