Fix #960, add socket shutdown implementation#976
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom May 3, 2021
Merged
Fix #960, add socket shutdown implementation#976astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Closed
jphickey
added
the
CCB:Ready
Contributor
|
Ping @excaliburtb |
skliper
approved these changes
Apr 28, 2021
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-04-28 APPROVED |
jphickey
force-pushed
the
integration-candidate
branch
from
c518e3f to
811d48a
Compare
jphickey
force-pushed
the
fix-960-socket-shutdown
branch
from
f7d9966 to
536789e
Compare
Adds an OS_SocketShutdown() wrapper around the BSD socket shutdown() API. This allows a data transfer of a stream socket to be gracefully shut down prior to socket closure.
jphickey
force-pushed
the
fix-960-socket-shutdown
branch
from
536789e to
0f98567
Compare
Contributor
Author
|
Rebased/pushed again to resolve some code coverage issues. This looks OK now. |
Contributor
Author
|
The branch was deleted by mistake, this is still needing merge |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 5, 2021
nasa/osal#973, UtPrintx function nasa/osal#976, add socket shutdown implementation
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 5, 2021
cfe v6.8.0-rc1+dev559 and osal v5.1.0-rc1+dev417 Combines: nasa/osal#979 nasa/cFE#1481 Includes: nasa/osal#973, UtPrintx function nasa/osal#976, add socket shutdown implementation nasa/cFE#1418, add ES CDS Functional test nasa/cFE#1429, Function comment blocks nasa/cFE#1414, Add Header Functional tests. nasa/cFE#1415, add Current Time Functional Test
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Keep names under 16 chars to make more debugger friendly, regardless of the OSAL limit.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#976, short background task name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds an OS_SocketShutdown() wrapper around the BSD socket shutdown() API. This allows a data transfer of a stream socket to be gracefully shut down prior to socket closure.
Fixes #960
Testing performed
Build and sanity check CFE, run all unit tests
The "network-api-test" program is enhanced with several more test cases to confirm that the shutdown functionality is working as intended.
Expected behavior changes
OS_SocketShutdown()API added. No effect unless API is used, existing code not changed.System(s) tested on
Ubuntu 20.04, RTEMS 4.11
Additional context
This PR depends on PR #971, so this is based on the IC right now.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.