Skip to content

Fix #963, improve documentation of UtAssert API calls#974

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
jphickey:fix-963-utassert-api
May 11, 2021
Merged

Fix #963, improve documentation of UtAssert API calls#974
astrogeco merged 1 commit intonasa:integration-candidatefrom
jphickey:fix-963-utassert-api

Conversation

@jphickey
Copy link
Contributor

Describe the contribution
The UtAssert API documentation was very terse and some references are obsolete/incorrect. This converts to doxygen form and
corrects the stale/incorrect references.

In particular - UtMemSet does not exist, but the standard C memset call should be used to fill a memory region with a constant value.

Fixes #963

Testing performed
Build and sanity check CFE, run all tests

Expected behavior changes
None - documentation only

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

The UtAssert API documentation was very terse and some references
are obsolete/incorrect.  This converts to doxygen form and
corrects the stale/incorrect references.

In particular - UtMemSet does not exist, but the standard C memset
call should be used to fill a memory region with a constant value.
@skliper
Copy link
Contributor

skliper commented Apr 27, 2021

Suggest adding in/out on params, but not critical.

@skliper skliper added this to the 6.0.0 milestone Apr 27, 2021
@jphickey jphickey closed this Apr 29, 2021
@jphickey jphickey deleted the fix-963-utassert-api branch April 29, 2021 13:21
@jphickey jphickey restored the fix-963-utassert-api branch April 29, 2021 17:17
@jphickey jphickey reopened this Apr 29, 2021
@jphickey
Copy link
Contributor Author

The branch was deleted by mistake, this is still needing merge

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 5, 2021
@astrogeco
Copy link
Contributor

CCB:2021-05-05 APPROVED

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 5, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate May 11, 2021 01:50
@astrogeco astrogeco added IC:2021-05-11 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 11, 2021
@astrogeco astrogeco merged commit 4e39dd0 into nasa:integration-candidate May 11, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request May 11, 2021
nasa/osal#978, configuration guide updates

nasa/osal#974, improve documentation of UtAssert API calls

nasa/osal#977, update OS_TaskCreate doc
astrogeco added a commit to nasa/cFS that referenced this pull request May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575
nasa/osal#996, osal v5.1.0-rc1+dev434

nasa/cFE#1487, Remove broken travis-ci script
nasa/cFE#1463, generated coverage stubs for CFE core
nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API
nasa/cFE#1451, OSAL config file simplification
nasa/cFE#1489, removes --quiet option so files checked go to stdout

nasa/osal#978, configuration guide updates
nasa/osal#974, improve documentation of UtAssert API calls
nasa/osal#977, update OS_TaskCreate doc
nasa/osal#997, Enable cppcheck results output
nasa/osal#980, Scrub return values
nasa/osal#992, add local mutex to BSP console
nasa/osal#993, do not require nonblock mode
astrogeco added a commit to nasa/cFS that referenced this pull request May 12, 2021
nasa/cFE#1492, cFE v6.8.0-rc1+dev575
nasa/osal#996, osal v5.1.0-rc1+dev434

nasa/cFE#1487, Remove broken travis-ci script
nasa/cFE#1463, generated coverage stubs for CFE core
nasa/cFE#1463, Move CFE_FS_RunBackgroundFileDump to internal API
nasa/cFE#1451, OSAL config file simplification
nasa/cFE#1489, removes --quiet option so files checked go to stdout

nasa/osal#978, configuration guide updates
nasa/osal#974, improve documentation of UtAssert API calls
nasa/osal#977, update OS_TaskCreate doc
nasa/osal#997, Enable cppcheck results output
nasa/osal#980, Scrub return values
nasa/osal#992, add local mutex to BSP console
nasa/osal#993, do not require nonblock mode

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
@jphickey jphickey deleted the fix-963-utassert-api branch February 24, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find recommended method (UtMemSet) suggested in comments

3 participants