Fix #944, add OS_API_Teardown#948
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Apr 11, 2021
Merged
Conversation
This cleans up all OSAL resources as best as possible, ideally leaving the system in a state where OS_API_Init() may be invoked again.
jphickey
force-pushed
the
fix-944-osapi-teardown
branch
from
35e7b04 to
7101da0
Compare
jphickey
added
the
CCB:Ready
Invoke OS_API_Teardown to reset state for next test
jphickey
force-pushed
the
fix-944-osapi-teardown
branch
from
b5f4071 to
ef34cf4
Compare
Contributor
Author
|
Updated, also including the fix for issue #197 in this PR (second commit) |
Contributor
|
CCB:2021-04-07 APPROVED |
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 12, 2021
Combines nasa/osal#956 nasa/cFE#1295 Including: nasa/osal#941 - Allow OSAL re-initialization nasa/osal#941 - Combine initialized and shutdown flags into one nasa/osal#948 - Add OS_API_Teardown nasa/osal#948 - Black Box Unit Tests Do Not Ensure Resources Are Cleaned Up Between Tests nasa/osal#940 - Rework shell test nasa/cFE#1276 - Use events for CFE test asserts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This cleans up all OSAL resources as best as possible, ideally leaving the system in a state where OS_API_Init() may be invoked again.
Fixes #944
Fixes #197
Testing performed
Build and run all unit tests, confirm correct behavior
Test in conjunction with fix for #197, confirm test can be run multiple times on VxWorks without reboot
Expected behavior changes
Adds OS_API_Teardown API to complement OS_API_Init
System(s) tested on
Ubuntu 20.04 (native)
MCP750 vxworks 6.9
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.