osal Integration candidate: 2021-03-30#927
Merged
Conversation
The "common_types.h" file will no longer provide these.
Improve the error codes from this function. - Introduces a new error "OS_ERR_OUTPUT_TOO_LARGE" if the size limit was insufficient (instead of OS_SUCCESS). - Return OS_ERROR if an empty file was written - this likely indicates some fundamental issue with the VxWorks symbol table. - Return OS_ERR_NAME_TOO_LONG if one of the symbol names was too long, (instead of generic OS_ERROR). Improve unit test to check for/verify these responses.
This function is no longer needed and has been a no-op since v5.0.0.
Fix #843, remove BIG/LITTLE bit order macros
Fix #846, Minor clean up and clarification in comments/naming
2 tasks
Fix #831, Finish os-impl-bsd-socket.c coverage testing
Do not initialize or compare osal_id_t directly to integers, use the provided comparison function.
Fix #888, better return codes from OS_SymbolTableDump_Impl
Fix #853, remove OS_TaskRegister
Fix #934, Remove unused SCRIPT_MODE flag
Fix #929, use test function for osal_id_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #843, remove BIG/LITTLE bit order macros
Fix #846, Minor clean up and clarification in comments/naming
Fix #831, Finish os-impl-bsd-socket.c coverage testing
Fix #888, better return codes from OS_SymbolTableDump_Impl
Fix #853, remove OS_TaskRegister
Fix #934, Remove unused SCRIPT_MODE flag
Fix #929, use test function for osal_id_t
Testing performed
osal checks https://github.com/nasa/osal/pull/927/checks
bundle checks https://github.com/nasa/cFS/pull/227/checks
Expected behavior changes
PR #878
Removes
SOFTWARE_BIG_BIT_ORDERandSOFTWARE_LITTLE_BIT_ORDERmacros fromcommon_types.h. These are not needed by OSAL and cannot handle all cases. Application code with endianness dependency that was relying on these symbols may break. Users should leverage code in cFE:cfe_endian.h. See nasa/cFE#1218 for more details.PR #918
Applies minor code and documentation cleanup: white space, typos, etc.
PR #923
Adds test to get full coverage of vxworks in
os-impl-bsd-socket.cresulting in full line coverage for OSALPR #915
Adds more descriptive return codes if
OS_SymbolTableDump_Impldoes not do what is expected. Adds a new errorOS_ERR_OUTPUT_TOO_LARGEif the size limit was insufficient. ReturnOS_ERRORif an empty file was written - this likely indicates some fundamental issue with the VxWorks symbol table. ReturnsOS_ERR_NAME_TOO_LONGif one of the symbol names was too long. Improves unit test to check for/verify these responses.PR #926
Removes the unneeded
OS_TaskRegister()and all references to it in code, tests, and documentation. No impact to behavior, but does affect API and has depenedenciesPR #935
Removes unused
-SCRIPT_MODEflag in cmakePR #930
Remove comparison between
osal_id_tandintegersto use the provided comparison function,OS_ObjectIdDefined(). System builds and runs again when using a type-safe/non-integer osal_id_t type.Additional context
Part of nasa/cFS#227
Authors
@skliper
@jphickey