HOTFIX: osal Integration candidate 2021-03-23#925
Merged
Conversation
The fcntl() function is documented as returning -1 on error, so test for this condition and report errno if so. There is no recourse/handling - this just reports the error. However - failure to set the O_NONBLOCK flag via this method will fall back to blocking mode being used (timeouts will not work as a result).
Fix #863, check/report fcntl status Fix Version and Readme to reflect correct buildnumber:350
skliper
approved these changes
Mar 23, 2021
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#923, Perform appid lookup early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #863
Testing performed
Bundle Tests https://github.com/nasa/cFS/pull/225/checks
Osal Tests https://github.com/nasa/osal/pull/925/checks
Expected behavior changes
See #910
System(s) tested on
Ubuntu 18.04
Additional context
Missing part of IC:2021-03-23
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey