Skip to content

Fix #833, Initialize file descriptor in OS_OpenCreate#834

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix833-init_filedes
Mar 1, 2021
Merged

Fix #833, Initialize file descriptor in OS_OpenCreate#834
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix833-init_filedes

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Mar 1, 2021

Describe the contribution
Fix #833 - Initializes the file descriptor (output parameter) for all cases in OS_OpenCreate

Avoids various "possible uninitialized variable" warnings for routines that utilize this API.

Testing performed
Build and execute unit tests, passed

Expected behavior changes
Avoids static analysis warning, output never unset.

System(s) tested on

  • Hardware: cFS Lab 5
  • OS: CentOS 7
  • Versions: Bundle main + this commit

Additional context
nasa/cFE#1185

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.0.0 milestone Mar 1, 2021
@skliper skliper force-pushed the fix833-init_filedes branch from ab99223 to 7b5c287 Compare March 1, 2021 14:34
@skliper skliper force-pushed the fix833-init_filedes branch from 7b5c287 to d1c4e8f Compare March 1, 2021 14:37
@astrogeco astrogeco changed the base branch from main to integration-candidate March 1, 2021 20:56
@astrogeco astrogeco merged commit 38e9d6c into nasa:integration-candidate Mar 1, 2021
@skliper skliper deleted the fix833-init_filedes branch April 1, 2021 20:06
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#818, Return message address from CFE_SB_SendMsg stub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always initialize file descriptor in OS_OpenCreate

3 participants