Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED by zanzaben · Pull Request #816 · nasa/osal

zanzaben · 2021-02-16T21:24:41Z

Describe the contribution
(would have fixed #752)
use UTASSERT_CASETYPE_NA instead of UtPrintf to report cases when not implemented

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

skliper

Also needs update:

osal/src/tests/symbol-api-test/symbol-api-test.c

Lines 46 to 68 in ff4f523

    
               /* 
        
               ** dump the symbol table with a 32768 byte limit 
        
               */ 
        
               UtPrintf("Dumping symbol table with a limit of 32768 bytes\n"); 
        
               status = OS_SymbolTableDump("/ram/SymbolTable32k.dat", 32768); 
        
               UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 32k OS_SymbolTableDump = %d", 
        
                             (int)status); 
        
               /* 
        
               ** dump the symbol table with a 128k byte limit 
        
               */ 
        
               UtPrintf("Dumping symbol table with a limit of 131072 bytes\n"); 
        
               status = OS_SymbolTableDump("/ram/SymbolTable128k.dat", 131072); 
        
               UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 128k OS_SymbolTableDump = %d", 
        
                             (int)status); 
        
               /* 
        
               ** dump the symbol table with a 512k byte limit 
        
               */ 
        
               UtPrintf("Dumping symbol table with a limit of 524288 bytes\n"); 
        
               status = OS_SymbolTableDump("/ram/SymbolTable512k.dat", 524288); 
        
               UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 512k OS_SymbolTableDump = %d", 
        
                             (int)status);

…MENTED

astrogeco · 2021-02-17T17:20:45Z

CCB 2021-02-17 Make a macro to replace multiple instances of "copy-pasted" code

skliper · 2021-03-09T17:21:25Z

This was rejected in favor of making a macro and using it in all these cases (could be done as part of #787 or independent)

Integration Candidate 2020-08-12

zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 16, 2021

astrogeco added the CCB:2021-02-17 label Feb 16, 2021

skliper suggested changes Feb 17, 2021

View reviewed changes

zanzaben force-pushed the fix752_uniform_not_implemented_tests branch from 9004e4c to ebef88b Compare February 17, 2021 15:10

Fix nasa#752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLE…

f92d6f4

…MENTED

zanzaben force-pushed the fix752_uniform_not_implemented_tests branch from ebef88b to f92d6f4 Compare February 17, 2021 15:13

astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 17, 2021

zanzaben closed this Feb 23, 2021

zanzaben deleted the fix752_uniform_not_implemented_tests branch February 23, 2021 17:18

skliper added the duplicate label Feb 24, 2021

zanzaben restored the fix752_uniform_not_implemented_tests branch March 9, 2021 15:11

skliper added invalid and removed duplicate labels Mar 9, 2021

skliper mentioned this pull request Mar 9, 2021

Consolidate around single base set of unit test APIs (can extend, but should be based on a consistent set) #787

Open

zanzaben mentioned this pull request Mar 16, 2021

Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED #914

Merged

jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022

Merge pull request nasa#816 from nasa/integration-candidate

a148b97

Integration Candidate 2020-08-12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED#816

Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED#816
zanzaben wants to merge 1 commit intonasa:mainfrom
zanzaben:fix752_uniform_not_implemented_tests

zanzaben commented Feb 16, 2021 •

edited by skliper

Loading

Uh oh!

skliper left a comment

Uh oh!

astrogeco commented Feb 17, 2021

Uh oh!

skliper commented Mar 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	/*
	** dump the symbol table with a 32768 byte limit
	*/
	UtPrintf("Dumping symbol table with a limit of 32768 bytes\n");
	status = OS_SymbolTableDump("/ram/SymbolTable32k.dat", 32768);
	UtAssert_True(status == OS_SUCCESS \|\| status == OS_ERR_NOT_IMPLEMENTED, "status after 32k OS_SymbolTableDump = %d",
	(int)status);

	/*
	** dump the symbol table with a 128k byte limit
	*/
	UtPrintf("Dumping symbol table with a limit of 131072 bytes\n");
	status = OS_SymbolTableDump("/ram/SymbolTable128k.dat", 131072);
	UtAssert_True(status == OS_SUCCESS \|\| status == OS_ERR_NOT_IMPLEMENTED, "status after 128k OS_SymbolTableDump = %d",
	(int)status);

	/*
	** dump the symbol table with a 512k byte limit
	*/
	UtPrintf("Dumping symbol table with a limit of 524288 bytes\n");
	status = OS_SymbolTableDump("/ram/SymbolTable512k.dat", 524288);
	UtAssert_True(status == OS_SUCCESS \|\| status == OS_ERR_NOT_IMPLEMENTED, "status after 512k OS_SymbolTableDump = %d",
	(int)status);

Conversation

zanzaben commented Feb 16, 2021 • edited by skliper Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skliper left a comment

Choose a reason for hiding this comment

Uh oh!

astrogeco commented Feb 17, 2021

Uh oh!

skliper commented Mar 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zanzaben commented Feb 16, 2021 •

edited by skliper

Loading