Fix #809, cast args to printf in queue-test#811
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 12, 2021
Merged
Fix #809, cast args to printf in queue-test#811astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Using %u conversion requires unsigned int arg, not necessarily uint32
skliper
approved these changes
Feb 12, 2021
Contributor
|
@astrogeco requesting fasttrack, broken. |
zanzaben
approved these changes
Feb 12, 2021
Contributor
|
Random label question, would this fall under unit-test? What kind of tests do we have under the "tests" directory? |
Contributor
|
@astrogeco I'd call it unit-test, for me that covers every kind of testing (not production code) |
Contributor
Should we then rename the label to |
Contributor
|
All I use it for is to filter if it's production code or not, I don't have an opinion over any smaller groups |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…al_Tests Fix nasa#811, add Mempool functional tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Using
%uconversion requires anunsigned intarg, notuint32(it matches on some platforms, not on others).Fixes #809
Testing performed
Build and run tests on RTEMS 4.11.3.
Expected behavior changes
No more format mismatch warning/error.
System(s) tested on
RTEMS 4.11.3 QEMU target on Ubuntu 20.04 build host
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.