Fix #805, Null terminate when using strncpy#807
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Feb 12, 2021
Merged
Fix #805, Null terminate when using strncpy#807astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
skliper
force-pushed
the
fix805-null_termination
branch
from
763a508 to
05e5fbe
Compare
jphickey
approved these changes
Feb 12, 2021
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
I like the sizeof() updates.
Note that for the two cases of strcpy it was already length-checked earlier in the function - so not a buffer overflow. But using strncpy is fine, if a bit redundant.
Contributor
Author
|
Yeah, saw that these weren't all actual bugs... but following the pattern is easier for quick compliance checks. |
Fix nasa#796, Update os-impl-no-sockets.c to match APIs
skliper
force-pushed
the
fix805-null_termination
branch
from
05e5fbe to
a8e0955
Compare
astrogeco
force-pushed
the
integration-candidate
branch
from
920fde8 to
c24982d
Compare
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#807, Add ES Application Behavior Functional Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #805 - fixed a couple missing null terminations and applied the general pattern (sizeof where it works)
Testing performed
Build and execute unit tests
Expected behavior changes
Avoid missing null termination issues, no longer truncating filename in OS_ModuleInfo (src/os/shared/src/osapi-module.c)
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC