Fix #796, Update os-impl-no-sockets.c to match APIs#800
Merged
Conversation
jphickey
approved these changes
Feb 12, 2021
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Thanks for fixing - Oversight in my testing of the token change! I tested for different OS's but clearly forgot to change enable/disable configs.
Contributor
Author
|
I'm for adding all TRUE and all FALSE to the CI matrix (along with the default) once we add back in the OSAL build/unit test workflow. At some point maybe add in a big and small config (as discussed at the Flight Software Workshop), it'd be fun to see how small a footprint we could achieve. These builds/runs don't take all that long so a 5x matrix seems reasonable. |
astrogeco
added a commit
that referenced
this pull request
Feb 12, 2021
Fix #796, Update os-impl-no-sockets.c to match APIs
astrogeco
added a commit
that referenced
this pull request
Feb 12, 2021
Fix #796, Update os-impl-no-sockets.c to match APIs
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #796 - updates os-impl-no-sockets.c to match latest APIs
Testing performed
Builds.
Expected behavior changes
Now can build without network (OSAL_CONFIG_INCLUDE_NETWORK FALSE)
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC