Fix #779, Change global vars to not be hidden by local vars.#794
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 24, 2021
Merged
Conversation
zanzaben
added
the
CCB:Ready
jphickey
requested changes
Feb 12, 2021
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
I'm not sure changing only the case is sufficient... I think there is a coding standard against that (i.e. having two different vars that differ only in capitalization).
Can we call the local one local_timer_id instead?
Contributor
|
Coding violation - Correct, I forgot about that one in my suggestion. |
zanzaben
force-pushed
the
fix779_local_hide_global_vars
branch
from
e123896 to
feff5b2
Compare
jphickey
approved these changes
Feb 12, 2021
skliper
approved these changes
Feb 12, 2021
Contributor
|
CCB 2021-02-17 APPROVED |
astrogeco
added
IC:2021-02-23
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 24, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 26, 2021
Bumps to: - cFE v6.8.0-rc1+dev365 - osal v5.2.0-rc1+dev280 - cFS-GroundSystem v2.2.0-rc1+dev29 See: - nasa/osal#830 - nasa/cFE#1171 - nasa/cFS-GroundSystem#162 Includes: - nasa/cFE#1148 - nasa/cFE#1168 - nasa/cFE#1158 - nasa/cFE#1151 - nasa/cFE#1173 - nasa/osal#794 - nasa/osal#818 - nasa/osal#820 - nasa/osal#815 - nasa/osal#813 - nasa/osal#822 - nasa/osal#823 - nasa/cFS-GroundSystem#156
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#794, Add msg stubs and update SB UT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #779
Rename global timer_id to local_timer_Id
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC