Fix #788, Resolve coercion alters value warnings#789
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Feb 12, 2021
Merged
Fix #788, Resolve coercion alters value warnings#789astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
zanzaben
approved these changes
Feb 10, 2021
jphickey
approved these changes
Feb 12, 2021
Contributor
Should we open an issue to update these to the "status type"? |
Contributor
Author
|
@astrogeco apparently I was thinking of the |
Closed
Contributor
Author
|
Just saw this duplicates #669 fix, noting here for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #788 - fixed two locations with local return code defined as uint32, should be int32 (or eventually the status type)
Testing performed
Build and execute unit tests, passed
Expected behavior changes
No functional change, just resolves warnings
System(s) tested on
Additional context
Static analysis warning
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC