Skip to content

osal Integration candidate: 2021-01-19#767

Merged
astrogeco merged 36 commits intomainfrom
integration-candidate
Jan 27, 2021
Merged

osal Integration candidate: 2021-01-19#767
astrogeco merged 36 commits intomainfrom
integration-candidate

Conversation

@astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jan 21, 2021

Describe the contribution

Fix #746, Add UtDebug message from OS_printf stub
Fix #692, Resolve typos in unit test assert OR statements
Fix #577, Document nested tests not supported
Fix #753, Remove UT_CheckForOpenSockets
Fix #229, add mqueue functional test
Fix #757, Readd extern C in osapi.h to support C++ use
Fix #692, display message when not implemented error occurs
Fix #591, add test teardown failure to test summary
Fix #699, format printf correctly
Fix #685, change file create to use read write
Fix #748, add additional casts
Fix #743, Create Security Policy
Fix #429, update OS_time_t definition to 64 ticks
Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree
Fix #761, Terminate string in TestReadWriteLseek
Fix #724, Refactor UT_ClearForceFail to UT_ClearDefaultReturnValue
Fix #722, update UT_SetDefaultReturnValue comments
Fix #229, mqueue test uses sequence of numbers
Fix #760, Install modules and clean up files for unit tests

Testing performed
See https://github.com/nasa/cFS/pull/177/checks

Expected behavior changes

PR #748

PR #759

PR #696

PR #747

PR #751

PR #763

PR #758

PR #725

PR #694

PR #754

PR #749

PR #739

PR #695

PR #735

PR #764

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#177

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@zanzaben
@skliper
@ArielSAdamsNASA

Jacob Hageman and others added 20 commits January 7, 2021 15:30
Use a single 64-bit tick counter as OS_time_t, rather than
a split 32 bit seconds + 32 bit microseconds counter.

This benefits in several ways:

- increases the timing precision by 10x (0.1us ticks)
- increases the representable range by 400x (+/-14000 yrs)
- simplifies addition/subtraction (no carry over)
- avoids "year 2038" bug w/32-bit timestamps
Users should call OS_FileSysStatVolume() and read the respective
output members of the structure as indicated.
Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree
Fix #743, Create OSAL Security Policy Markdown
Fix #746, Add UtDebug message from OS_printf stub
Fix #577, Document nested tests not supported
@astrogeco
Copy link
Contributor Author

@skliper,

Got a segfault after adding #747

81/81 Test #81: sample_lib-sample_lib .............***Exception: SegFault  0.10 sec

96% tests passed, 3 tests failed out of 81

Total Test time (real) = 143.67 sec

The following tests FAILED:
	 69 - cfe-core_es_UT (Failed)
Errors while running CTest
	 71 - cfe-core_evs_UT (SEGFAULT)
	 81 - sample_lib-sample_lib (SEGFAULT)
Makefile:138: recipe for target 'test' failed
make: *** [test] Error 8
Error: Process completed with exit code 2.

See https://github.com/nasa/cFS/pull/177/checks?check_run_id=1742875628

@astrogeco astrogeco marked this pull request as ready for review January 27, 2021 00:34
@astrogeco astrogeco merged commit 09a2c5e into main Jan 27, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment