Fix #718, deprecate OS_fsBlocksFree and OS_fsBytesFree#759
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jan 21, 2021
Merged
Conversation
Users should call OS_FileSysStatVolume() and read the respective output members of the structure as indicated.
skliper
approved these changes
Jan 15, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 21, 2021
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…_deprecated fix nasa#759 - deprecates GetLastSenderId()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Deprecates the
OS_fsBlocksFree()andOS_fsBytesFree()functions because the return value is inadequate for larger file systems.Users should call OS_FileSysStatVolume() and read the respective output members of the structure as indicated.
Fixes #718
Testing performed
Build CFE and unit test with both OMIT_DEPRECATED as true and false
Expected behavior changes
Any calls to these functions will become an error if building with
OMIT_DEPRECATED=trueSystem(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.