Fix #757, Read extern C in osapi.h to support C++ use#758
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jan 21, 2021
Merged
Fix #757, Read extern C in osapi.h to support C++ use#758astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
changed the title
skliper
force-pushed
the
fix757-cpp_typo
branch
from
686f3f0 to
df458a3
Compare
|
Looks like this solves my issue. |
jphickey
approved these changes
Jan 14, 2021
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Whoops .. perhaps part of our CI should include a C++ app?
Thanks for finding/fixing.
astrogeco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #757, Readd extern C in osapi.h to support C++ use
Testing performed
Build and unit test, passes.
@johnphamngc - could you test in C++ context and confirm this resolves your issue?
Expected behavior changes
Works to include header in C++ again, no other functional change
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC