Fix #692, fix or statements#739
Conversation
zanzaben
added
the
CCB:Ready
zanzaben
force-pushed
the
fix692_network_api_state_or_assertions
branch
from
0427074 to
ff06b57
Compare
|
How about" Fix #692, Resolve typos in unit test assert OR statements"? |
zanzaben
force-pushed
the
fix692_network_api_state_or_assertions
branch
from
ff06b57 to
4b65be0
Compare
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Looking closer I'd recommend something like:
if (actual == OS_ERR_NOT_IMPLEMENTED)
{
UtPrintf("XXX API not implemented");
}
else
{
... do rest of the test
}
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Needs auto-formatting applied, otherwise great improvement.
|
Side note - not implemented isn't actually considered and "error", test passes either way (and it's OK for OSAL/OS's to not implement all API functionality). |
zanzaben
force-pushed
the
fix692_network_api_state_or_assertions
branch
from
ca5ed76 to
33aefa4
Compare
Well then it shouldn't be called os_ERR_not_implemented |
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Good point! In the context of FSW it is an error, and brings up that we should probably be flagging the not implemented cases as UTASSERT_CASETYPE_NA so they get explicitly counted/reported. Lets address that as a separate issue though.
zanzaben
force-pushed
the
fix692_network_api_state_or_assertions
branch
from
33aefa4 to
a928734
Compare
|
CCB 2021-01-13 APPROVED @skliper opened related issue to make finding "not implemented" items |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
Add more hooks for additional flexibility when adding modular code blobs into the build. Three new directives are added: MISSION_CORE_MODULES, for modular components which are direct dependencies of CFE core and/or extend its functionality. MISSION_GLOBAL_APPLIST, for applications/libraries which should be built for every target, as if they were listed in every TGTx_APPLIST setting. MISSION_GLOBAL_STATIC_APPLIST, same as above but for the TGTx_STATIC_APPLIST setting. This also simplifies/reworks the search path to remove some logic that was never really utilized.
3 participants
Describe the contribution
Fixes #692
fixed the or statement to correctly compare against both options.
Testing performed
Build and run unit test
Expected behavior changes
will correctly cath failures when they happen
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC