Fix #697, use POSIX dir implementation on VxWorks6#706
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jan 13, 2021
Merged
Fix #697, use POSIX dir implementation on VxWorks6#706astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Instead of maintaining a one-off implementation for VxWorks 6, use the POSIX implementation for this module. The only incompatibility is the prototype for mkdir() which is missing the second argument. This can be worked around with a simple compatibility macro that is only enabled for VxWorks 6.x builds.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Dec 29, 2020
Contributor
|
CCB 2021-01-06 APPROVED |
astrogeco
added
CCB-20210106
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Instead of keeping/maintaining a one-off implementation for VxWorks 6, use the POSIX implementation for this module. The only incompatibility is the prototype for mkdir() which is missing the second argument. This can be worked around with a simple compatibility macro that is only enabled for VxWorks 6.x builds. This replaces previous PR #698.
Fixes #697.
Testing performed
Build and run all unit tests
Sanity check CFE
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04 (native)
VxWorks 6.9 (mcp750)
Additional context
The actual posix dir implementation did not change at all - just using it on VxWorks 6.9 too.
Also translates/converts the coverage test cases from vxworks specific to the portable dir implementation, which benefits VxWorks7, RTEMS and POSIX too.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.