Skip to content

Fix #542, Avoid UT failure if SEM_VALUE_MAX >= UINT32_MAX#681

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix542-semvaluemax_wrap
Dec 18, 2020
Merged

Fix #542, Avoid UT failure if SEM_VALUE_MAX >= UINT32_MAX#681
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix542-semvaluemax_wrap

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Dec 9, 2020

Describe the contribution
Fix #542 - avoids a potential unit test failure if an invalid semaphore value can not be passed in

Testing performed
Build and run unit tests, passed

Expected behavior changes
None.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Unable to reproduce error from issue (requires feedback from @mbenson1) but this fix avoids a potential error case.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper force-pushed the fix542-semvaluemax_wrap branch from 3ef419d to 9a73cb5 Compare December 9, 2020 19:30
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 9, 2020
@astrogeco astrogeco added CCB-20201216 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 16, 2020
@astrogeco
Copy link
Contributor

CCB 2020-12-16 APPROVED

  • Found an integer rollover, user hasn't provided feedback to further identify bug

@astrogeco astrogeco changed the base branch from main to integration-candidate December 18, 2020 14:43
@astrogeco astrogeco merged commit d32af54 into nasa:integration-candidate Dec 18, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 18, 2020
@skliper skliper deleted the fix542-semvaluemax_wrap branch February 1, 2021 21:36
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VxWorks OS_CountSemCreate unit test fails

2 participants