Fix #410, breakup includes#675
Conversation
jphickey
added
the
CCB:Ready
|
Only marked as draft because it requires a baseline which is not yet in |
astrogeco
added
CCB-20201209
and removed
CCB:Ready
|
CCB 2020-12-09 APPROVED
|
Includes compatibility wrappers for the old header names. Refactors inclusions in all OSAL source files to only include the components they actually use/refer to. Refactor all inclusion guards to follow the same general format (uppercase filename, no leading/trailing underscore)
jphickey
force-pushed
the
fix-410-breakup-includes
branch
from
7cd2fd1 to
f0bd42e
Compare
|
Rebased to "main" and made all requested changes. Note I used a regex script to replace all the include guards to match the requested pattern, as well as to use quoted filenames instead of bracketed filenames in |
|
@astrogeco can we move this one forward? It touches everything so the quicker we can get it in the less we are going to have to deal with conflicts. |
| @@ -30,207 +30,18 @@ | |||
| #ifndef _osapi_loader_ | |||
There was a problem hiding this comment.
Do we want to fix this include guard even though the file is deprecated?
There was a problem hiding this comment.
@astrogeco can we move this one forward? It touches everything so the quicker we can get it in the less we are going to have to deal with conflicts.
I'll merge it now and we can revisit my commit in the IC as a hotfix if we want to fix include guard styles for deprecated code.
There was a problem hiding this comment.
FWIW - I had skipped updating these files because they were deprecated... will probably remove in a future commit with the rest of the deprecated stuff in this cycle.
3 participants
Describe the contribution
Break up
osapi-os-*.hfiles into units which correspond to the implementation units. The old header file names still exist for compatibility.Fix #410
Testing performed
Build and run CFE and unit tests.
Expected behavior changes
None - just header refactoring, no actual change.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.