Fix #670, clean up task definitions in core test#671
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 17, 2020
Merged
Fix #670, clean up task definitions in core test#671astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Move all definitions and instantiations out of the header file. Reuse the single task definition that was already defined. Also only define 3 instances of each type, as this is all that the test actually uses (no need for 20).
jphickey
added
the
CCB:Ready
skliper
approved these changes
Dec 8, 2020
Contributor
|
CCB 2020-12-09 APPROVED |
astrogeco
added
CCB-20201209
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Move all definitions and instantiations out of the header file. Reuse the single task definition that was already defined.
Also only define 3 instances of each type, as this is all that the test actually uses (no need for 20).
Fixes #670
Testing performed
Build and run the unit tests
Expected behavior changes
Test Tasks do not run at 100%
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.