Skip to content

Fix #631, Add new functional tests for OS_chmod#665

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
zanzaben:fix631-chmod-functional-test
Dec 9, 2020
Merged

Fix #631, Add new functional tests for OS_chmod#665
astrogeco merged 1 commit intonasa:integration-candidatefrom
zanzaben:fix631-chmod-functional-test

Conversation

@zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Dec 1, 2020

Describe the contribution
Fixes #631 by adding new function tests

Testing performed
These new test, but ran them on the branch from #650

Expected behavior changes
The new tests added to make test

Additional context
Dependant on #650

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 1, 2020
@astrogeco astrogeco added CCB-20201202 dependency and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 2, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Dec 2, 2020

CCB 20201202 - APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate December 9, 2020 14:59
@astrogeco astrogeco changed the title fix #631 add new functional tests for OS_chmod Fix #631, Add new functional tests for OS_chmod Dec 9, 2020
@astrogeco astrogeco merged commit 9d5034d into nasa:integration-candidate Dec 9, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 9, 2020
@astrogeco
Add nasa/osal#665
d64ec12
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 9, 2020
@astrogeco
Add nasa/osal#665
fee32eb
@astrogeco astrogeco mentioned this pull request Dec 9, 2020
Merged
@jphickey
Copy link
Contributor

jphickey commented Dec 10, 2020

Unfortunately this PR appears to have broken the file-api-test on RTEMS ....

[BEGIN] 04 TestChmod
OS_FileOpen_Impl():111:open(/RAM/Filename1): Invalid argument
[ FAIL] 04.001 file-api-test.c:257 - status after creat = -1
[ FAIL] 04.002 file-api-test.c:259 - status after close = -16

@astrogeco
Copy link
Contributor

astrogeco commented Dec 10, 2020

Unfortunately this PR appears to have broken the file-api-test on RTEMS ....

[BEGIN] 04 TestChmod
OS_FileOpen_Impl():111:open(/RAM/Filename1): Invalid argument
[ FAIL] 04.001 file-api-test.c:257 - status after creat = -1
[ FAIL] 04.002 file-api-test.c:259 - status after close = -16

Can you open an issue? @zanzaben do you have a way to test on RTEMS?

@jphickey jphickey mentioned this pull request Dec 11, 2020
Closed
@zanzaben
Copy link
Contributor Author

zanzaben commented Dec 14, 2020

Unfortunately this PR appears to have broken the file-api-test on RTEMS ....

[BEGIN] 04 TestChmod
OS_FileOpen_Impl():111:open(/RAM/Filename1): Invalid argument
[ FAIL] 04.001 file-api-test.c:257 - status after creat = -1
[ FAIL] 04.002 file-api-test.c:259 - status after close = -16

Can you open an issue? @zanzaben do you have a way to test on RTEMS?

I do not have a way to test on RTEMS

@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@zanzaben
Fix nasa#665, update pipe name documentation.
80fca94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependency

Projects

None yet

Milestone

Caelum

Development

Successfully merging this pull request may close these issues.

OS_chmod missing functional test

4 participants

@zanzaben @astrogeco @jphickey @skliper