Fix #655, use 3 argument form of open#656
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Dec 1, 2020
Merged
Fix #655, use 3 argument form of open#656astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Contributor
|
Ping @excaliburtb |
skliper
approved these changes
Nov 17, 2020
Contributor
|
CCB 2020-11-18 APPROVED |
Contributor
|
@astrogeco Is it possible to fasttrack this? Impacts stakeholders. |
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 1, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
VxWorks only provides the 3 argument form of
open(). Passing 0 as the mode solves the build issue. This parameter is ignored when not creating a file.Fixes #655
Testing performed
Build and sanity check CFE
Expected behavior changes
No behavior change. Fixes build issue on VxWorks 6.9
System(s) tested on
VxWorks 6.9
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.