Fix #637, fix OS_ModuleUnload for static modules#638
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Nov 10, 2020
Merged
Fix #637, fix OS_ModuleUnload for static modules#638astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-637-module-unload
branch
from
902f09a to
6d74eb4
Compare
astrogeco
added
CCB-20201104
and removed
CCB:Ready
Mark static modules with a different type, and check that type at unload. Only call unload low level implementation if type is dynamic.
jphickey
force-pushed
the
fix-637-module-unload
branch
from
6d74eb4 to
ba6375c
Compare
Contributor
|
CCB 2020-11-04 APPROVED
|
ghost
approved these changes
Nov 4, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This looks good to me. I like the support for static modules.
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 10, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 16, 2020
* Add nasa/cFE#984 * Add nasa/cFE#980 * Add nasa/cFE#867 * Add nasa/osal#638 and update cfe due to rebase * Add nasa/cFE#987 * Add nasa/to_lab#64 and nasa/sample_app#104 * Add nasa/osal#643 * Add nasa/cFE#1000 * Add nasa/ci_lab#58 * Add doxygen fixes for nasa/osal#643 * Add nasa/cFE#1013 * Add nasa/cFE#1011 * Add nasa/ci_lab#61 * Add nasa/sample_app#109 * Bump versions and point to submodules main Co-authored-by: Joseph Hickey <[email protected]>
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#399, Deprecate decompress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Ensure that the handle is not NULL before invoking
dlclose(). In particular the handle will be NULL for static modules.Fixes #637
Testing performed
Build and sanity test CFE with apps linked statically.
Expected behavior changes
System(s) tested on
Ubuntu 20.04
i686-rtems4.11 / pc686 via QEMU
Additional context
This issue only affects statically linked apps, which "go through the motions" of module loading for consistency in operation, but do not actually load a module - because its already linked.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.