Skip to content

Fix #327 and #333, Squash LGTM warnings#633

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix327-lgtm-recommended
Nov 2, 2020
Merged

Fix #327 and #333, Squash LGTM warnings#633
astrogeco merged 1 commit intonasa:integration-candidatefrom
skliper:fix327-lgtm-recommended

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Oct 22, 2020

Describe the contribution

Testing performed
Built and ran unit tests, passed.

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: bundle main + this commit

Additional context
#630, #632 - new issues from FIXME
#631 - uncovered missing functional test on OS_chmod

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 22, 2020
@skliper skliper added this to the 6.0.0 milestone Oct 22, 2020
@astrogeco astrogeco added CCB-20201028 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 28, 2020
@astrogeco
Copy link
Contributor

CCB 2020-10-28 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate October 30, 2020 15:45
@astrogeco astrogeco merged commit 0d706ca into nasa:integration-candidate Nov 2, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 2, 2020
@skliper skliper deleted the fix327-lgtm-recommended branch February 1, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lgtm issues for os-impl-posix-files.c, osapi-filesys.c Recommended lgtm osal issues

2 participants