Fix #628, Update UtAssert macros with dynamic string formatting#629
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Nov 3, 2020
Merged
Fix #628, Update UtAssert macros with dynamic string formatting#629astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
asgibson
added
enhancement
unit-test
skliper
approved these changes
Oct 22, 2020
skliper
added
the
CCB:Ready
astrogeco
added
CCB-20201028
conflicts
and removed
CCB:Ready
Contributor
|
CCB 2020-10-28 APPROVED |
Contributor
|
@asgibson can you resolve the merge conflicts on this? |
Contributor
Author
astrogeco
changed the title
Contributor
|
@asgibson I went ahead and rebased your branch on top of integration-candidate, two tips for next time:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Changed all UtAssert macros to take variable string arguments, feature request #628
Testing performed
Steps taken to test the contribution, cFS/main branch commit 20097ef64e455ace25a1535ea43090a739eb7c0c:
https://github.com/nasa/cFS/
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
UtAssert_True wrapper around call will no longer be necessary to accommodate dynamic string output, thus removing the double assert. UtAssert macros will now be able to offer more information by themselves.
System(s) tested on
PC, RHEL 7.6
Contributor Info - All information REQUIRED for consideration of pull request
Alan Gibson NASA GSFC/587