Conversation
These functions are replaced by OS_OpenCreate, which implements both functions via flags, and follows the correct OSAL API patterns.
Change use of uint32 for ID to the correct typedef. Use ObjectIdFromInteger/ObjectIdToInteger where it is intended to convert these values to integers e.g. for the "name" fields in RTEMS.
Fix #618, Use osal_id_t in RTEMS implementation
Fix #556, Deprecate OS_open and OS_creat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #556
Fix #618
Testing performed
See Bundle PR - https://github.com/nasa/cFS/pull/147/checks
Expected behavior changes
PR #617 - Deprecate
OS_openandOS_creatto and replaced them with byOS_OpenCreate, which implements both functions via flags, and follows the correct OSAL API patterns.PR #619 - Change use of uint32 for ID to the correct typedef. Also use ObjectIdFromInteger/ObjectIdToInteger where it is intended to convert these values to integers e.g. for the "name" fields in RTEMS.
System(s) tested on
Ubuntu CI
Additional context
Part of nasa/cFS#147
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey