Fix #556, Deprecate OS_open and OS_creat#617
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Oct 13, 2020
Merged
Fix #556, Deprecate OS_open and OS_creat#617astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
These functions are replaced by OS_OpenCreate, which implements both functions via flags, and follows the correct OSAL API patterns.
jphickey
added
the
CCB:Ready
astrogeco
added
CCB-20201006
CCB:Ready
Contributor
|
CCB 2020-10-06 APPROVED
|
astrogeco
added
IC-20201013
and removed
breaking
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Oct 13, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#617, Updates comments to note that the length limit of OS_MAX_PATH_LEN and OS_MAX_API_NAME includes null terminator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
These functions are replaced by OS_OpenCreate, which implements both functions via flags, and follows the correct OSAL API patterns.
Fixes #556
Testing performed
Build and run all tests, sanity check CFE
Check coverage of file-related APIs (still 100%)
Expected behavior changes
OS_open()andOS_create()are deprecated.System(s) tested on
Ubuntu 20.04
Additional context
This initially puts the items inside an
OSAL_OMIT_DEPRECATEDblock for review and testing, like has been done traditionally.Should discuss at CCB whether this should become a hard-cut given that the next release will be a major one.
Although the previous discussions on the topic agreed to hard cut at major releases, these are such widely-used routines that this will cause grief to a lot of users.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.