Fixed typo in rtems binsem TimeInTicks variable name#614
Closed
adam-stamand wants to merge 1 commit intonasa:mainfrom
adam-stamand:main
Closed
Fixed typo in rtems binsem TimeInTicks variable name#614adam-stamand wants to merge 1 commit intonasa:mainfrom adam-stamand:main
adam-stamand wants to merge 1 commit intonasa:mainfrom
adam-stamand:main
Conversation
skliper
added
the
CCB:Ready
skliper
approved these changes
Oct 2, 2020
jphickey
approved these changes
Oct 2, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Confirmed this is broken in main ... which was surprising because I just tested using RTEMS recently but I had the previous OSAL baseline apparently (from 9-21) so didn't run into this issue.
I'm also getting another warning too:
/home/joe/code/cfecfs/github/osal/src/os/rtems/src/os-impl-binsem.c: In function 'OS_BinSemTimedWait_Impl':
/home/joe/code/cfecfs/github/osal/src/os/rtems/src/os-impl-binsem.c:249:5: error: implicit declaration of function 'OS_Milli2Ticks' [-Werror=implicit-function-declaration]
if (OS_Milli2Ticks(msecs, &TimInTicks) != OS_SUCCESS)
^
Contributor
|
Suggests we really should push ahead with adding RTEMS + VxWorks builds to our CI somehow.... |
Contributor
Yes. Would really help catch my errors... |
This was referenced Oct 2, 2020
Closed
Contributor
|
Fixed in #616 |
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This addresses a typo in the rtems os-impl-binsem.c file for a variable name.
Fixes #613
Testing performed
Compiled using rtems toolchain, but not run on hardware.
Expected behavior changes
Prior to this change, compilation failed for an rtems platform. The code should now compile for rtems.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Adam St. Amand - Personal