Merged
Conversation
- Removed OS_Tick2Micros implementation, tests, stubs, references - Moved prototype from API to internal for OS_Milli2Ticks - Updated OS_Milli2Ticks to return status - Added check for rollover in OS_Milli2Ticks - OS_Milli2Ticks now sets and limits ticks as int - Updated all internal use of OS_Milli2Ticks to check for error and returns immediately on error (won't wait maximum amount) - Coverage tests updated to check for new error cases - OS_Milli2Ticks stub updated (default implementation)
Fix #104, Remove OS_Tick2Micros and internalize OS_Milli2Ticks
Fix #604, Add ut_assert address equal macro
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 24, 2020
Integration Candidate includes: nasa/cFE#912 nasa/osal#607
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 24, 2020
* IC-20200923: Updating submodules to main. Integration Candidate includes: nasa/cFE#912 nasa/osal#607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #104
Fix #604
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/142/checks
Expected behavior changes
PR #603 - Removes OS_Tick2Micros and internalize OS_Milli2Ticks.
PR #605 - Adds ut_assert address equal macro.
System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#142
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC