Merged
Conversation
The C library type is signed, and this makes the result check work as intended.
Move this existing function into the public API, as it is performs more verification than the OS_ConvertToArrayIndex function.
Fix #589, promote OS_ObjectIdToArrayIndex to public API
Fix #593, change OCS_off_t to a signed type
The name mismatch triggered a doxygen warning.
yammajamma
added a commit
to nasa/cFS
that referenced
this pull request
Sep 15, 2020
Integration Candidate: 2020-09-09 Integration candidate includes: nasa/cFE#876 nasa/osal#596 nasa/cFS-GroundSystem#135
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update ES coverage test to use preferred macros. Adds dedicated assert macros for checking fixed-length string buffers, and for checking memory offsets. Also adds an improved implemention of the syslog/printf check which filters out newlines (keeps log more parseable).
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update EVS coverage test to use preferred macros
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update SB coverage test to use preferred macros. Adds a dedicated assert macro for checking SB MsgId values.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update MSG coverage test to use preferred macros
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update SBR coverage test to use preferred macros
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update TBL coverage test to use preferred macros
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update TIME coverage test to use preferred macros
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Update FS coverage test to use preferred macros.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Clean up the assert functions and macros which are no longer used after updating all coverage tests to use preferred macros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #589
Fix #593
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/139/checks
Expected behavior changes
PR #595 - Move this existing function into the public API, as it is performs more verification than the
OS_ConvertToArrayIndexfunction.
PR #594 - The C library type is signed, and this makes the result check work as intended.
System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#139
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.